-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ingest #6
Draft
j23414
wants to merge
12
commits into
master
Choose a base branch
from
ingest
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jun 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 55e13da - Browse repository at this point
Copy the full SHA 55e13daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0233699 - Browse repository at this point
Copy the full SHA 0233699View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5600aa7 - Browse repository at this point
Copy the full SHA 5600aa7View commit details -
refactor: flag intermediate files as temp
Flags most of the intermediate representations of sequences and metadata as temporary files such that we only keep the final compressed outputs. Deleting the intermediate files reduced the data directory size from 221MB to 584 KB.
Configuration menu - View commit details
-
Copy full SHA for 477979b - Browse repository at this point
Copy the full SHA 477979bView commit details -
Since serotype is annotated as a column in metadata, simplify intermediate filenames like `data/sequences_{serotype}.fasta` and `data/metadata_{serotype}.tsv` to `data/sequences.fasta` and `data/metadata.tsv`.
Configuration menu - View commit details
-
Copy full SHA for e80815f - Browse repository at this point
Copy the full SHA e80815fView commit details -
In ingest/README.md, assume user is within ingest directory.
Configuration menu - View commit details
-
Copy full SHA for a17b2f0 - Browse repository at this point
Copy the full SHA a17b2f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for fad2af9 - Browse repository at this point
Copy the full SHA fad2af9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c060a0 - Browse repository at this point
Copy the full SHA 5c060a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1f36e2 - Browse repository at this point
Copy the full SHA a1f36e2View commit details -
edit: Use a permalink for each script
This would allow us to version the software we use in this workflow without being affected by upstream changes until we want to bump the version. This design adds more maintenance to this workflow, but it also protects users against unexpected issues that are outside of their control.
Configuration menu - View commit details
-
Copy full SHA for a157df7 - Browse repository at this point
Copy the full SHA a157df7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a2c5c4 - Browse repository at this point
Copy the full SHA 5a2c5c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ad1636 - Browse repository at this point
Copy the full SHA 6ad1636View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.