Add arm64 to image builds
#48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces the existing scripts with GitHub Actions provided by Docker. Also has the benefit of using buildx which supports building multi-arch images (to be done later): https://docs.docker.com/desktop/multi-arch/ Sequence of steps inspired by the following guides: - https://github.com/docker/build-push-action/blob/master/docs/advanced/multi-platform.md - https://github.com/docker/build-push-action/blob/master/docs/advanced/isolated-builders.md Not sure if isolated builders are needed here though. It might be more efficient to have one build and push to both base and builder images, if that's even possible? Or, to cut some time, build the two images in parallel using 2 jobs in this workflow.
victorlin
force-pushed
the
victorlin/use-buildx
branch
from
f891905 to
0b4fb2d
Compare
|
👀 …widely-supported enough by the x86 family of chips! 🙃 |
|
Guess we'll need to not compile FastTree with x86 instruction set features on non-x86 chips. |
This was referenced Jun 14, 2022
Merged
|
Oh oops I misread, totally RAxML not FastTree. |
|
Closed in favor of #50. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Sequence of steps inspired by the following guides:
Related issue(s)
Testing
See checks.
TODO
arm64build (see checks)