Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tables in narratives look acceptable #966

Merged

Conversation

joachimschmidt557
Copy link
Contributor

Meant to address #887

Before:

image

After:

image

@jameshadfield jameshadfield temporarily deployed to auspice-css-tables-glob-fv6rv7 March 22, 2020 22:46 Inactive
@jameshadfield jameshadfield merged commit d66f6a7 into nextstrain:master Mar 23, 2020
@jameshadfield
Copy link
Member

Great! Thanks @joachimschmidt557. Tested using nextstrain.org's theme customization and looks great.

@joachimschmidt557 joachimschmidt557 deleted the css-tables-global branch March 23, 2020 08:47
jameshadfield added a commit that referenced this pull request Mar 24, 2020
The styling introduced in #966 was global, which meant (e.g.) the tip-clicked panel display was changed (undesired side effect). This moves the CSS introduced there into the styled components used by the narratives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants