Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add axis labels for Rectangular and Clock Phylogeny trees. #942

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

newhouseb
Copy link
Contributor

As requested in #941.

Rectangular view:

Rect

Clock view:

Clock

I haven't done serious front-end work for a long time, so feedback is welcome!

@jameshadfield jameshadfield temporarily deployed to auspice-xaxislabel-nouehnlps4h March 13, 2020 05:08 Inactive
@jameshadfield jameshadfield merged commit 71fb2a8 into nextstrain:master Mar 13, 2020
@jameshadfield
Copy link
Member

Thanks @newhouseb -- really appreciate this work, it's fantastic. This is a common source of misinterpretation currently and this PR really helps.

I added 3 commits onto the PR which i'm happy to talk through if you have any questions:

  • c74edc5 - Add comments & use strict equality checks
  • 3380872 - Use correct axis to infer mutations vs divergence
  • cd057b5 - Fix x-axis label position for second trees

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants