Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special case GISAID EPI ISL and Genbank accession #850

Merged
merged 6 commits into from
Jan 27, 2020
Merged

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Jan 27, 2020

We want the ability to have accessions for viruses that are in both GISAID and Genbank. This PR watches for nodes with attrs gisaid_epi_isl and genbank_accession and treats them separately from the normal accession and url logic.

GISAID EPI ISL gets a hover element, while both GISAID EPI ISL and Genbank accession get click elements.

trvrb added 2 commits January 26, 2020 15:45
This looks for node attr `gisaid_epi_isl` and puts it in the hover box.
If `gisaid_epi_isl` or `genbank_accession` exist as node attrs, these preempt normal use of `accession` and `url`.
@trvrb trvrb requested a review from jameshadfield January 27, 2020 00:18
includes comment to indicate the special behavior introduced during nCoV response
to indicate the special nature of `gisaid_epi_isl`
@jameshadfield jameshadfield merged commit 23509dc into master Jan 27, 2020
@jameshadfield jameshadfield deleted the accessions branch January 27, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants