Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we change the concept of minor grid lines for temporal trees to represent "sensible" periods of time rather than fitting a fixed number between major grid points. This will greatly aid in epidemiological understanding of trees. Major grid lines are also chosen using a new heuristic which attempts to pick sensible periods, and is responsive to screen sizes to avoid a squashed grid on small screens.
No modifications are made to the calculation of grids for divergence trees.
Examples:
☝️ minor grid lines represent days here
☝️ small screens look better, and the minor gridlines are still meaningful (here each minor grid is 1 week)
☝️ large screens can show lots of information. Here minor gridlines represent months.
☝️ a potentially unwanted side effect -- here weeks don't fit nicely into multi-month major gridlines, so the spacing of minor gridlines is less aesthetically pleasing. I'd argue it's more epidemiologically informative. This can be changed - for instance here we could have minor grid lines show months instead.
☝️ a improvement common to a lot of datasets - minor gridlines represent months
☝️ often you see fewer grid lines, but they are easier to understand