preserve color-by order for v2 JSONs #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With v2 JSONs, the intention is that the provided ordering is respected by auspice.
This allows us keep the color-by ordering expected from v1 JSONs whilst allowing v2 JSONs to define the order themselves.
|
Closes #820 |
|
Sorry. I can review. But looks great in general. |
|
No worries, it's all working as expected. I'm going to release a new auspice version with some minor fixes to various things now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows v2 JSONs to define the color ordering as intended.
The previous sorting behavior is moved to the server in order to preserve expected v1 JSON behavior.