Dynamically add tip labels #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`useModifySVGInStages` is false unless `newLayout` is set to true. Thus, set `useModifySVGInStages = newLayout`.
Previously, `updateTipLabels()` was not being called when modifying the SVG after a layout change.
Previously, tip labels would not update in visibility unless the SVG or layout was modified, or the page was reloaded. Now tip labels reflect date range changes.
tsibley
approved these changes
Jun 4, 2019
| @@ -306,9 +306,6 @@ export const change = function change({ | |||
| elemsToUpdate.add(".grid").add(".regression"); | |||
| svgPropsToUpdate.add("cx").add("cy").add("d").add("opacity").add("visibility"); | |||
| } | |||
| if (newLayout) { | |||
| useModifySVGInStages = true; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
💯 This type of refactor is small but I think really helpful to iteratively making complex logic more understandable/approachable.
|
Thanks for cleaning this up. Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the issues stated in Issue #237, namely around tip labels appearing/disappearing dynamically.
The remaining work from that issue is on tip label transitioning and editing the hardcoded # of branches selected.
Because this issue was marked as high priority, I thought I'd open this PR in case the team wanted it merged before everything in the issue was resolved.