-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate (improved) download ability #587
Conversation
fix bug regarding "&" character in SVG
@jameshadfield --- This is great. Some small things that I noticed in review:
I wonder about instead making it take up the entire display and give it a big x in the top right? This is also because it's not visually consistent with the other modals. Other modals are dark grey background with rounded corners and white text. If you're going for a modal where you click outside, make it consistent with other modals in the app.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #587 (comment)
We need to centralize the styles better
@trvrb points 1-3 have been addressed now and I think this is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thank you for humoring me here James.
One small comment that's worth thinking about even if I don't have an immediate solution: The download modal states
But then clicking download "strain metadata" or "author metadata" downloads all 502 strains and 82 authors. |
Go ahead and merge whenever you'd like @jameshadfield. |
This PR re-enables downloading of data, and closes #562.
Improvements
d
is a shortcut for downloading the SVGKnown bugs
window.L
and/orthis.state.map.remove()
within<Map>
, however this causes fatal leaflet errors. I remember @colinmegill having troubles here so don't think the fix is simple.)clipPath
, however this resulted in internal elements which crossed the boundary also being removed.In general, the
mapDemesAndTransmissions
SVG is rather complicated and @colinmegill would have the most knowledge here. On the flipside, when the map contains errors they are rather obvious ;)