Meta safety checks #586
Meta safety checks #586
Conversation
App now works without meta.author_info. The tip info box just doesn't display these fields.
Previously, entropy was always drawn even if panels did not specify it.
App now works when meta.annotations is absent. Almost completely functional. Color by genotype doesn't do anything, but this is better than the previous crash behavior.
Drop map panel if geo is absent
If meta.panels absent default to just displaying tree
Default to colorBy="none" when color_options is absent. When colorBy = "none", fall back to simple grayscale colorScale.
App now works without meta.json!
|
Looks good. Will make sure things work today -- could you modify https://github.com/nextstrain/static/blob/master/content/docs/03-bioinformatics-pipeline/05-exported-JSON-files.md please? re: drag & drop, technically it's not hard, but I remember discussing this with you in the past and deciding not to take auspice in this direction. Happy to revisit. |
With nextstrain/augur#134 closed. I think drag-and-drop is less important. But this is a general decision that should be made.
Sure thing. Waiting for augur PR to go in. |
|
Metadata description updated: nextstrain/static@6a52873 |
@jameshadfield ---
I went through and systematically tested removal of each field in
meta.jsonand corrected errors associated with removal of each. I even got it to the point where the app works ifmeta.jsonis completely absent. Here is Zika from modular augur without ameta.jsonfile:It defaults to just the tree as entropy is impossible without
meta.annotationsand map is impossible withoutmeta.geo. But I think this is pretty great. I tested this with other tree JSONs and it's working for other pathogens as well.@rneher --- This is my proof of principle for intermediate tree JSON files in augur (nextstrain/augur#134). They will be easily viewable.
I would recommend making this drag-and-drop, but I'll need help from @jameshadfield to make this happen.