Make authors filter an explicit setting in auspice_filters #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jameshadfield: This makes it so that
state.filters.authorsis only added if it's explicitly set in meta.json. I've added this to augur builds for Zika, Ebola, etc... Everything except seasonal flu and H7N9. I did this because currently, taking assubmitting_labasauthorsvia GISAID is pretty broken. Take a look at this from H7N9:A bunch of strange et als. But more severely,
Other Database Import et alcontributing most of the data. This just looks bad. We should clean this up in sacra (cc @barneypotter24) and don't rely on auspice appending "et al".All the necessary changes have been made to JSONs for this to work live.