-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset title, better filter display & download modal #462
Conversation
Other style tweaks in the footer
@trvrb I think this is ready to be merged now |
Thanks @jameshadfield. There were a couple small bits of logic that I was wanting to adjust. I'll do this now and then we can merge if you're happy with them. |
@jameshadfield --- I just removed date filters from the info box. I didn't like how the numbers flipped through while dragging date slider. I you feel strongly I'm happy to discuss / undo. I also disable the data download button so that this can be merged now and not depend on #431 (I'll do this, I promise). We still need new JSONs for flu, H7N9 and Ebola, but this can happen before pushing live (and it's not terrible without the new JSONs). Going to merge now. |
This PR introduces
Blocking:
Notes:
controls
can be removed from the metadata JSON, but this can be left in for now.Screenshots