Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset title, better filter display & download modal #462

Merged
merged 25 commits into from
Sep 30, 2017
Merged

Dataset title, better filter display & download modal #462

merged 25 commits into from
Sep 30, 2017

Conversation

jameshadfield
Copy link
Member

This PR introduces

  • a title ("info") card above the map/tree, which contains the dataset title and a list of active filters (see screenshots). This card is collapsable via a toggle.
  • an expanded footer to contain all available filters (see screenshots)
  • the removal of filters from the sidebar
  • the download modal is now running.

Blocking:

Notes:

Screenshots

image

image

image

image

image

@jameshadfield
Copy link
Member Author

@trvrb I think this is ready to be merged now

@trvrb
Copy link
Member

trvrb commented Sep 30, 2017

Thanks @jameshadfield. There were a couple small bits of logic that I was wanting to adjust. I'll do this now and then we can merge if you're happy with them.

@trvrb
Copy link
Member

trvrb commented Sep 30, 2017

@jameshadfield --- I just removed date filters from the info box. I didn't like how the numbers flipped through while dragging date slider. I you feel strongly I'm happy to discuss / undo.

I also disable the data download button so that this can be merged now and not depend on #431 (I'll do this, I promise).

We still need new JSONs for flu, H7N9 and Ebola, but this can happen before pushing live (and it's not terrible without the new JSONs).

Going to merge now.

@trvrb trvrb merged commit d984c93 into master Sep 30, 2017
@trvrb trvrb deleted the filters branch September 30, 2017 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display author and title when filtering by author
2 participants