Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up measurements Redux states/actions #1881
Clean up measurements Redux states/actions #1881
Changes from 1 commit
d9e679d
7599aa7
047de26
a5bc80f
0f67361
0861269
a2431ae
947eda6
6c2308a
cab837e
0069e09
c03d336
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a dataset without measurements
measurementsData=false
so we're getting the warning message when we shouldn't. This happens because while the dispatch object setsmeasurementsData: undefined
that won't override the default arg value ofcreateStateFromQueryOrJSONs({measurementsData = false, ...})
. This is a feature / bug of JS depending on your point of view:You can use
null
if you want, but I'd suggestfalse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch, I'll go with
false
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up just checking
measurementsData
is a falsy value in 0069e09.