feat: remove missing geo_resolutions warning #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When` .meta.geo_resolutions` are not present, Auspice prints a console warning: ``` JSONs did not include `geoResolutions` ``` My understanding is that it is not a required field: https://github.com/nextstrain/augur/blob/0eab3357376f0fe7347fe60dd75dbc2fb01bed33/augur/data/schema-export-v2.json#L18 and auspice can function without it. It seems to have been added a long time ago: https://github.com/nextstrain/auspice/blame/a537d390e6a54214ea084240a292da786479693e/src/actions/recomputeReduxState.js#L548 I propose to remove the warning. My goal here is to clean up the dev console of Nextclade. Just being a purist here (I like my console to be clean :)), but if this warning is useful in other contexts, I don't insist.
jameshadfield
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
When
.meta.geo_resolutionsare not present, Auspice prints a console warning:My understanding is that it is not a required field: https://github.com/nextstrain/augur/blob/0eab3357376f0fe7347fe60dd75dbc2fb01bed33/augur/data/schema-export-v2.json#L18 and auspice can function without it.
It seems to have been added a long time ago:
https://github.com/nextstrain/auspice/blame/a537d390e6a54214ea084240a292da786479693e/src/actions/recomputeReduxState.js#L548
I propose to remove the warning. My goal here is to clean up the dev console of Nextclade. Just being a purist here (I like my console to be clean :)), but if this warning is useful in other contexts, I don't insist.
Related issue(s)
Checklist