Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Data updated" date to byline #1715

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Oct 19, 2023

Description of proposed changes

This seems like important information that shouldn't only be buried at the bottom of the page.

Keep the existing text at the bottom for users who are used to finding it there.

Suggested by @joverlee521.

Related issue(s)

Closes #1713.

Testing

@victorlin victorlin self-assigned this Oct 19, 2023
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-move--aajohu October 19, 2023 23:30 Inactive
src/components/info/byline.js Outdated Show resolved Hide resolved
@victorlin victorlin force-pushed the victorlin/move-date-updated branch from 67d8806 to 60815b4 Compare October 20, 2023 17:16
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-move--aajohu October 20, 2023 17:16 Inactive
@victorlin victorlin changed the title Move "Date updated" to byline Move "Data updated" date to byline Oct 20, 2023
@victorlin victorlin force-pushed the victorlin/move-date-updated branch from 60815b4 to 21ddfc8 Compare October 20, 2023 17:19
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-move--aajohu October 20, 2023 17:19 Inactive
src/components/framework/fine-print.js Outdated Show resolved Hide resolved
This seems like important information that shouldn't only be buried at
the bottom of the page.

Keep the existing text at the bottom for users who are used to finding
it there.

Suggested by @joverlee521.
@victorlin victorlin force-pushed the victorlin/move-date-updated branch from 21ddfc8 to 8bcbe1a Compare October 20, 2023 17:42
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-move--aajohu October 20, 2023 17:43 Inactive
@victorlin victorlin changed the title Move "Data updated" date to byline Add "Data updated" date to byline Oct 20, 2023
@victorlin victorlin merged commit ba7e1c2 into master Oct 20, 2023
19 checks passed
@victorlin victorlin deleted the victorlin/move-date-updated branch October 20, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move "Date updated" to the top of the page
5 participants