Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs development experience #1609

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Dec 5, 2022

Description of proposed changes

See commit messages.

Related issue(s)

N/A

Testing

Text before this change did not address environment setup.

To be consistent with other docs projects under Nextstrain, use a direct
call to `make` instead of an `npm` alias.
@victorlin victorlin requested a review from a team December 5, 2022 22:15
@victorlin victorlin self-assigned this Dec 5, 2022
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-docs--27igtb December 5, 2022 22:16 Inactive
Super handy for edit/preview cycles in dev.

Originally from nextstrain/docs.nextstrain.org@2598f4e
@victorlin victorlin force-pushed the victorlin/docs/autobuild branch from 7c2654a to 377d821 Compare December 5, 2022 22:18
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-docs--27igtb December 5, 2022 22:18 Inactive
Copy link
Member

@tsibley tsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @jameshadfield may have opinions here as well.

Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working well. livehtml is indeed a much nicer experience. It's still complicated that we have separate conda environments for each RTD project, but that's a higher-level issue (and one which is arguably not worth the effort to solve).

I'll merge this now (easiest of 7 PRs in auspice which I hope to tackle today).

@jameshadfield jameshadfield merged commit ad5a1b3 into master Dec 6, 2022
@jameshadfield jameshadfield deleted the victorlin/docs/autobuild branch December 6, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants