Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Node.js references #1551

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Sep 21, 2022

Description of proposed changes

The current docs are unclear about which versions of Node.js are supported, and recommend an outdated version for installation.

Related issue(s)

N/A

Testing

  • Preview of changes looks good

@victorlin victorlin requested a review from a team September 21, 2022 01:48
@victorlin victorlin self-assigned this Sep 21, 2022
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-updat-nacksg September 21, 2022 01:48 Inactive
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In anther PR we should update engines.node. I'll make an issue...

v12 has reached end-of-life and should be dropped

We should support v18. I'm running it day-to-day without problems, apart from needing the the NODE_OPTIONS=--openssl-legacy-provider flag (I can't remember the specifics of why this is needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants