Detect duplicate or missing node names #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every now and again we have an issue with a dataset with duplicate node names, which results in an incredibly uninformative auspice stack trace. While this is ultimately a problem with the dataset itself it's simple to detect this and change it to a unique name within Auspice (with a helpful console message). For good measure we also deal with the case where a node name was missing entirely. Note that both of these datasets would fail `augur validate export-v2 <JSON>`.
jameshadfield
force-pushed
the
fix/duplicate-node-names
branch
from
9447f8e to
10e5407
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every now and again we have an issue with a dataset with duplicate
node names, which results in an incredibly uninformative auspice
stack trace. While this is ultimately a problem with the dataset itself
it's simple to detect this and change it to a unique name within
Auspice (with a helpful console message). For good measure we also
deal with the case where a node name was missing entirely.
Note that both of these datasets would fail
augur validate export-v2 <JSON>.