Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show labels for subtree root nodes #1503

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Conversation

jameshadfield
Copy link
Member

@jameshadfield jameshadfield commented Apr 28, 2022

This commit is related to the recent PR #1501 which hid (non-aa) labels
depending on their in-view tip-fraction. Here if the label is on the
root of a subtree then we always show it (unless the label is "aa" as
these can be very long).

Without this change, when exploding by "emerging lineage" only BA.1.1 would be labelled in the following screenshot (when not exploded, then only BA.1.1 is labelled, as per #1501)

image
image

This commit is related to the recent PR #1501 which hid (non-aa) labels
depending on their in-view tip-fraction. Here if the label is on the
root of a subtree then we always show it (unless the label is "aa" as
these can be very long).
@trvrb
Copy link
Member

trvrb commented Apr 28, 2022

Good call. Definitely agree with this addition.

@jameshadfield jameshadfield merged commit c8cf8ab into master Apr 28, 2022
@jameshadfield jameshadfield deleted the show-subtree-labels branch April 28, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

2 participants