-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap to "experimental" icon for exploded trees sidebar option #1486
Conversation
This swaps the previous use of "[experimental]" to a cleaner looking icon. I chose a wrench, thinking that this best represents work in progress.
Thanks James! I understand that the wrench isn't conveying "experimental" to you. I guess I was thinking of it most as "in progress" or "under construction". I'm having a bit of difficulty with the beaker as it conveys "science" to me rather than "experimental". But that said, after looking a bit I don't have a better suggestion. Out of the three For tooltip, I'd think to just use the regular |
a0b9baa
to
2894860
Compare
(Force pushed to fix the typo in the on-hover text.) |
Thanks @jameshadfield! I'm happy with the beaker, but I do have a preference here for consistency in how the explanatory tooltips behave. In the current PR, if you mouseover any of the text in "Explode Tree By" or the beaker icon you get that explanatory tooltip with "This functionality is experimental and should be treated with caution! Exploding a tree by trait X means that for each branch where the trait changes value..." This is different from the explanatory tooltip for "Tree Options", etc... where you get nothing when you mouseover the text, but you get the tooltip when you mouseover the (i). I really like having the visual cue that you can mouseover to get explanatory text. I'd recommend either:
I lean towards option 2. |
This adds styled components for a "SidebarSubtitle" with an on-hover info box. As we build out more of these we may need to re-asses the exact styling if it becomes too busy.
Note that we now have a custom-styled react-select component via PR #1482.
2894860
to
968899e
Compare
Thanks @trvrb -- implemented option 1 as I felt people may not hover over the experimental icon. I didn't originally do this as I was worried about having too many "info" icons, but even if we built them for all of the options it's not actually too bad (and if we do get here, we can tweak the styles further): |
Looks great. Thanks James! |
Description of proposed changes
This swaps the previous use of "[experimental]" in the "Explode tree by" sidebar option to a cleaner looking icon. I chose a wrench, thinking that this best represents work in progress.
Testing
I've tested locally, but it should be a small enough change that it should be safe.