Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metadata download from GISAID datasets #1366

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Jul 3, 2021

Description of proposed changes

This commit uses dataProvenance in metadata to identify datasets using "GISAID" data. For these datasets, the full metadata download is swapped to an "acknowledgments" download that only includes the following fields:

  • strain
  • gisaid_epi_isl
  • genbank_accession
  • originating_lab
  • submitting_lab
  • author

This should fulfill GISAID's request to not allow download of metadata table from data sourced from GISAID.

Testing

This has been tested locally and downloaded TSVs examined. Testing was done on datasets that are specified with GISAID provenance vs datasets without.

This commit uses dataProvenance in metadata to identify datasets using "GISAID" data. For these datasets, the full metadata download is swapped to an "acknowledgments" download that only includes the following fields:
 - strain
 - gisaid_epi_isl
 - genbank_accession
 - originating_lab
 - submitting_lab
 - author
@trvrb trvrb requested a review from jameshadfield July 3, 2021 19:40
@jameshadfield jameshadfield temporarily deployed to auspice-gisaid-metadata-od72oa July 3, 2021 19:40 Inactive
@trvrb trvrb merged commit f1f9824 into master Jul 6, 2021
@trvrb trvrb deleted the gisaid-metadata-download branch July 6, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants