-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow node traits to define URLs #1308
Conversation
The schema defines these as "special" property, and we use them to render the value and link to be rendered via `<AccessionAndUrl>` within the tip-clicked panel. These should not be available as valid traits for general display.
This extends our interpretation of dataset-supplied traits to allow them to define a URL as well as a value. If a url is specified, then the value (in the tip-clicked panel) is rendered as a link. Closes #1307
This improves our validation of URLs which should improve app stability.
Fantastic, thanks for doing this so quickly! Can you fire up another heroku so I can give it a try? (Or better yet, merge it! :) |
Following on from #1308 which allowed node attrs to be links, this allows them to load different datasets. The code here isn't well tested, but provides a starting point for linking together trees.
Awesome! This is a nice addition. |
Thanks again for adding this -- super-useful. Maybe it's my JSON, maybe I need to wait a bit longer for nextstrain.org to update? but this isn't working for me yet on nextstrain.org, i.e. the
https://nextstrain.org/fetch/hgwdev.gi.ucsc.edu/~angie/subtreeUrl.json?label=nuc%20mutations:T23155C |
This functionality is available in the latest auspice release (v2.25.0) but this hasn't made it to nextstrain.org yet. It's currently available at dev.nextstrain.org for final testing, and should arrive in nextstrain.org over the next day or two. |
Ah, I forgot about dev.nextstrain.org! It's working great, thanks so much!
…On Tue, Mar 30, 2021 at 6:16 PM james hadfield ***@***.***> wrote:
This functionality is available in the latest auspice release (v2.25.0)
but this hasn't made it to nextstrain.org yet.
It's currently available at dev.nextstrain.org for final testing, and
should arrive in nextstrain.org over the next day or two.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1308 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABNUZYGUFEDT4POHX2VB6TTGJZVNANCNFSM4ZNZZSKA>
.
--
*Angie Hinrichs, *Bioinformatics Programmer
UCSC Genome Browser <https://genome.ucsc.edu/>
UC Santa Cruz Genomics Institute <https://genomics.ucsc.edu/>
Revealing life’s code.
Google Scholar
<https://scholar.google.com/citations?view_op=search_authors&hl=en&mauthors=UCSC+Genome+Browser>|
Twitter <https://twitter.com/GenomeBrowser> | Facebook
<https://www.facebook.com/ucscGenomeBrowser/> | YouTube
<https://www.youtube.com/channel/UCQnUJepyNOw0p8s2otX4RYQ/videos>
|
This PR extends traits defined on nodes to allow an optional
url
property, which results in a link being rendered in the tip-clicked panel.As an example, this allows the following node structure to be rendered as follows:
(P.S.
colorings
in the dataset JSON provides a title forpangolin_lineage
,recency
andoriginating_lab
, which results in them being rendered asPANGO Lineage
,Submission Date
andOriginating Lab
).Additionally the code around processing URL strings has been improved and tests added.
Closes #1307