Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically define value which will always be false #1269

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Statically define value which will always be false #1269

merged 1 commit into from
Jan 29, 2021

Conversation

kairstenfay
Copy link
Contributor

At this '!==' operation, left operand 'nextProps.geoResolution' and
right operand 'this.props.geoResolution' always have the same value
because of the condition
this.props.geoResolution !== nextProps.geoResolution above.

Description of proposed changes

Simplifies a small chunk of code by statically defining the boolean value false.

At this '!==' operation, left operand 'nextProps.geoResolution' and
right operand 'this.props.geoResolution' always have the same value
because of the condition
`this.props.geoResolution !== nextProps.geoResolution` above.
@jameshadfield jameshadfield temporarily deployed to auspice-pr-1205-extndmxaej6rcm January 21, 2021 21:25 Inactive
@kairstenfay kairstenfay mentioned this pull request Jan 21, 2021
@trvrb trvrb merged commit e8e8b58 into master Jan 29, 2021
@trvrb trvrb deleted the pr/1205 branch January 29, 2021 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants