Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update footer and fine print #1260

Merged
merged 6 commits into from
Jan 11, 2021
Merged

Update footer and fine print #1260

merged 6 commits into from
Jan 11, 2021

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Jan 10, 2021

Description of proposed changes

This PR makes slight updates to content of the footer by:

  1. Updating the very bottom "Nextstrain: Hadfield et al, Bioinformatics (2018)" to read instead "Powered by Nextstrain (Hadfield et al Bioinformatics)" with a Nextstrain logo that links back to nextstrain.org. This is intended to be kept when a fork that reskins aspects of Auspice is made. "Powered by..." makes sense in both the nextstrain.org context as well as cloned contexts.
  2. Fixes /gisaid pathname to not automatically hide sidebar
  3. Splits Footer and FinePrint components so that instances that use query param onlyPanels. Keep important fine print information (date updated, version number and "Powered by Nextstrain...") displayed.
  4. Replace list of logos in the bottom of Splash with the same "Powered by Nextstrain..." element. This makes it easier for clones to not touch logos and leave "Powered by Nextstrain..." in place.

trvrb added 3 commits January 10, 2021 12:19
GISAID iFrames have been updated to include query param 'sidebar=closed' and so this logic is no longer needed.
This splits the Footer component (Description + Filters) from the FinePrint component (Version, Citation, Download).

This allows showOnlyPanels to keep displaying fine print.
@trvrb trvrb requested a review from jameshadfield January 10, 2021 21:46
@jameshadfield jameshadfield temporarily deployed to auspice-footer-xgkm7lplhqbxvbc January 10, 2021 21:46 Inactive
Previously the dataset listing had a row of logos at the bottom as seen on nextstrain.org. This commit swaps these logos for the same "Powered by Nextstrain..." fine print used at the bottom of the main Auspice view. This should work better for forks of Auspice.
@trvrb trvrb temporarily deployed to auspice-footer-xgkm7lplhqbxvbc January 10, 2021 22:54 Inactive
Allows the (default auspice) splash page to import the code from `fine-print.js`.
@jameshadfield jameshadfield temporarily deployed to auspice-footer-xgkm7lplhqbxvbc January 11, 2021 02:15 Inactive
@jameshadfield jameshadfield merged commit 83d4e46 into master Jan 11, 2021
@jameshadfield jameshadfield deleted the footer branch January 11, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants