-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tip labels to be user selected #1246
Conversation
This is super cool James!! We might also want to filter out 'genotype' as a tip label. It would actually be pretty cool to enable this but I imagine it would be more work - we could always come back to that in future! For short term might be good to just leave off the list. |
Adds an additional dropdown box to allow users to change the attribute used as tip labels. This is similar in design to the branch label drop down. Currently attributes are limited to the colorings. The function which collects these, `collectAvailableTipLabelOptions` could be easily extended to produce further valid attributes. This should pave the way for smarter and more customisable logic around _when_ labels are displayed, and the dropdown should not be shown in the situation that labels aren't shown. For a full description, see #1201 Closes #1201
43a5f9b
to
0e55b30
Compare
Tip label formats now updated to turn dates into pretty strings and genotype removed from the available options. (Genotype would make sense as a labeling when the coloring is also genotype, but implementing this would entail more complex logic which is best left for a subsequent PR.) |
This is fantastic, @jameshadfield. Completely changes the navigation experience. My only request now is that it go up on auspice.us, so the counties working with private data/trees can see the PII they're looking for! Thanks again for the feature! |
+1 -- I added a bug report for this somewhere or other :)
…On Thu, Jan 28, 2021 at 11:13 AM Joshua Batson ***@***.***> wrote:
This is fantastic, @jameshadfield <https://github.com/jameshadfield>.
Completely changes the navigation experience.
My only request now is that it go up on auspice.us, so the counties
working with private data/trees can see the PII they're looking for!
Thanks again for the feature!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1246 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADAIYX32EXMAEHNXVL4QQNLS4GZPFANCNFSM4VATFQJA>
.
|
Adds an additional dropdown box to allow users to change the attribute used as tip labels. This is similar in design to the branch label drop down.
Currently attributes are limited to the colorings. The function which collects these,
collectAvailableTipLabelOptions
could be easily extended to produce further valid attributes.This should pave the way for smarter and more customisable logic around when labels are displayed, and the dropdown should not be shown in the situation that labels aren't shown.
For a full description, see #1201
Closes #1201
@allenkj2 and @batson could you test this for me please? (I can't add you as reviewers due to GitHub collaboration settings)