Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: polyfill Promise to avoid crashes in old browsers #1217

Merged
merged 1 commit into from
Oct 7, 2020
Merged

fix: polyfill Promise to avoid crashes in old browsers #1217

merged 1 commit into from
Oct 7, 2020

Conversation

ivan-aksamentov
Copy link
Member

Description of proposed changes

This adds Promise polyfill before async entrypoint.
This is "solution 2" in the linked issue. See there for more details.

Related issue(s)

Fixes #1213

Testing

Tested in a some of the old browsers, as described in the issue

Thank you for contributing to Nextstrain!

Always glad

Resolves #1213

This adds `Promise` polyfill before async entrypoint.
This is "solution 2" in the linked issue. See there for more details.
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ivan-aksamentov -- I've tested this and can find no faults, although I don't have access to IE so I'm trusting this fixes the issues you identified!

@jameshadfield jameshadfield merged commit ba5fdf4 into nextstrain:master Oct 7, 2020
@ivan-aksamentov ivan-aksamentov deleted the fix/crash-in-old-browsers branch October 7, 2020 02:47
@ivan-aksamentov
Copy link
Member Author

ivan-aksamentov commented Oct 8, 2020

@emmahodcroft Could you please double-check https://dev.nextstrain.org in IE and pre-chromium Edge on your side?

My understanding that this fix is now deployed there and it should work.

@emmahodcroft
Copy link
Member

Old edge: Looks good!
IE: Looks good!

I loaded main page & ncov/global, zoomed in and out a bit, & filtered.

It seemed a bit slower than Chrome but that might just be my overloaded computer. But setting the colorings, for example, sometimes took a few seconds, and had a totally blank screen for half a second or so. That might be because it's dev not the normal? May also depend on the coloring. But overall, all works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old browsers crash on unpollyfilled Promise
3 participants