Enable narratives to source multiple builds - Add Ons #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salvatore-fxpig
changed the title
salvatore-fxpig
force-pushed
the
1050-mult-narratives-more
branch
2 times, most recently
from
1ce32ea to
6c322d9
Compare
|
This looks really good to me (I haven't actually faked a slow connection to test the case where we change to a narrative slide who's cached json is a pending promise, but it's within an |
salvatore-fxpig
force-pushed
the
1050-mult-narratives-more
branch
from
f5962ec to
591134e
Compare
|
Merged into #1164, thank you @salvatore-fxpig! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Just adding some magic sauce to #1164
Dunno if you've pulled in my fork, this may make it easier on your end (or not!)