Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies our settings for DOMpurify to allow SVG tags (and tags used within SVG).
You can see a test narrative here. This will be available vie the review app also.
For this to work we removed the
ALLOWED_ATTR
sanitizer config settings, but I note that the docs state "The included default configuration values are pretty good already". An alternate approach would be to also remove theALLOWED_TAGS
setting as the default allows SVG.