Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function 'recurse' defined at line 8 takes 2 arguments, but it was ca… #1077

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

rleir
Copy link
Contributor

@rleir rleir commented Apr 19, 2020

Hi all
In src/util/setGenotype.js, function 'recurse' defined at line 8 takes 2 arguments, but it was called with 3 arguments at line 40.

Description of proposed changes

What is the goal of this pull request? What does this pull request change?
This PR is trivial, and fixes some invalid JavaScript. The problem is harmless (other than code readability), so please feel free to ignore this PR.

Related issue(s)

Fixes #
Related to #

Testing

What steps should be taken to test the changes you've proposed?
I ran a linter program to verify that the syntax and calling semantics are correct.

If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?
Yes, I would like help testing this. Sorry for submitting a PR without testing, please feel free to ignore this PR. Thanks -- Rick

Thank you for contributing to Nextstrain!

Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jameshadfield jameshadfield merged commit c61f0e1 into nextstrain:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants