Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: display comment on PR if visual integration tests fail #1076

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Apr 19, 2020

Description of proposed changes

This adds to @tihuan's work on #1068 which needs to be landed first.

Once #1068 is landed, if someone happens to break screenshot testing in GitHub actions, there's no way to see what happened (this could be a major issue if actions are failing, but local tests are passing).

I've built a GitHub App and service which, once installed on a repository, will comment with screen shots on a PR, if integration tests are broken:

screen

It can be seen in action on a testing repo here.

Related issue(s)

Related to #917

Testing

I've tested thoroughly with the GitHub App installed on a testing repository.

Thank you for contributing to Nextstrain!

@tihuan tihuan mentioned this pull request Apr 19, 2020
@bcoe
Copy link
Contributor Author

bcoe commented Apr 21, 2020

@jameshadfield is there a good email to reach you at, perhaps you could send me a note at bencoe [at] google.com?

I'd like to float an idea with you about how we could host this bot (_and potentially any other bots that you think would be helpful).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants