Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1035 - Color-by changes result in duplicate function calls #1075

Merged
merged 3 commits into from
Apr 19, 2020

Conversation

andressrudqvist
Copy link
Contributor

Description of proposed changes

Implement shouldComponentUpdate() method in the ColorBy component for avoid function calls duplication.

Related issue(s)

Fixes #1035

Testing

Uncomment the console.log statement, inn change() inside change.js add . And run the application, check in console for one invocation per color change.

Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & confirmed that this results in fewer dispatches with no changes in behavior. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color-by changes result in duplicate (expensive) function calls
2 participants