Add license/copyright field to narratives #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sidneymbell this looks fine to me. Could you rebase onto master now that most of the changes in this PR have gone in via another PR? |
sidneymbell
force-pushed
the
narratives-license-copyright-field
branch
from
bca0681 to
9531544
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adds a field for a license, copyright, etc. This uses the same function as the previous
parseContributors, renamed toparseAttributionsto be a bit more generic. This will probably be used for a single string +/- link most of the time, but allowing arrays enables adding both a license and a copyright.Testing
Usage:
Yields:
