522 Add conf intervals to URL query string #1046
Merged
+59
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eharkins
changed the title
|
Another potential bug:
Trying to sort out where exactly, so I can include a fix in this PR. |
dont show conf interval toggle for div trees; also consolidate logic for state.controls.temporalConfidence.display
allow confidence interval svgs to be added
use a function in place of hardcoded logic about whether or not to display confidence intervals
|
@jameshadfield I think this is ready to merge if you want to take one last look.
|
jameshadfield
approved these changes
Apr 19, 2020
There was a problem hiding this comment.
Thanks Eli -- this looks good and will help with communicating uncertainty around branch timings in narratives which is really important right now 👍 Also thanks for tracking down & fixing related bugs discovered during this PR which touched many parts of Auspice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Note: this is a work in progress and was submitted early as a PR for @jameshadfield and I to discuss and test in staging on Heroku.
This will close #522 by adding the confidence intervals for the time trees to the URL query string so that they may be more easily shared, e.g. in narratives.
I was also hoping to include a fix to #1051 here as it seems relevant, so I will update the name of the PR accordingly when I push those commits.
Related issue(s)
#522
#1051
#1053
Testing
Given that the relevant part of the redux store (
state.controls.temporalConfidence) has these three pieces:exists: does the confidence interval exist for the value in question in the dataset?display: given the tree controls settings in the current redux state, does it make sense to have confidence intervals displayed on the tree?on: is the confidence intervals toggle switch on?, I will need to test transitioning to/from as many permutations of these three options as I can manually by changing the sidebar controls - as @jameshadfield pointed out, this would be much accelerated by automated front-end testing, which it seems like is in development (Add E2E testing #917)!