Add Portuguese translation and bug fixes #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clouradev
changed the title
jameshadfield
requested changes
Mar 30, 2020
There was a problem hiding this comment.
Hi @clouraa -- thanks for this 😄
(1) Could you add translations for the following strings (please ignore those which are the same in Portuguese as in English)
$ npm run diff-lang -- pt
PT: comparing sidebar.json against the English translation
Following keys are identical to the English version & may need to be translated:
"radial"
"Animation Speed"
PT: comparing translation.json against the English translation
Following keys are identical to the English version & may need to be translated:
"Nucleotide {{nuc}}"
"Click to zoom out to parent clade"
(2) Could you remove the search-box commit. I'm going to implement this functionality via #1026 which (a) breaks long strings onto multiple lines (b) instead of making the search box 100% it makes it the same size as the other UI elements in the sidebar.
|
Changes have been made. Only radial remains the same. |
|
Thanks again Cleiton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
I have translated all key-values to Portuguese.
Fixed bug in search strains
Related issue(s)
[i18n] Translate Auspice to Portuguese
[BUG] Search Strain Autocomplete is not sized properly