Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tangletree URL does not match for Lassa #706

Closed
trvrb opened this issue Feb 20, 2019 · 1 comment
Closed

Tangletree URL does not match for Lassa #706

trvrb opened this issue Feb 20, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@trvrb
Copy link
Member

trvrb commented Feb 20, 2019

Small bug I just noticed. If you go to:

https://nextstrain.org/lassa/s:l

You properly got the "s" segment / "l" segment tangletree, but the URL is updated to:

https://nextstrain.org/lassa/s
@trvrb trvrb added the bug Something isn't working label Feb 20, 2019
jameshadfield added a commit that referenced this issue Feb 27, 2019
@jameshadfield
TangleTree URLs are now correct when tree is last part of the URL
51ccced 
See issue #706. Note that this server logic is only currently used for local auspice versions, not nextstrain.org.
jameshadfield added a commit to nextstrain/nextstrain.org that referenced this issue Feb 27, 2019
@jameshadfield
TangleTree URLs are now correct when tree is last part of the URL
8fcbe07 
Closes Auspice issue nextstrain/auspice#706
@jameshadfield
Copy link
Member

jameshadfield commented Feb 27, 2019 •
edited
Loading

Fixed in nextstrain.org via commit: nextstrain/nextstrain.org@8fcbe07
And in auspice via commit: 51ccced

Note that addressing #687 will shift the logic for this from the server to the client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trvrb @jameshadfield