[tanglegrams] RHS tree branch label keys not collected #1780
Labels
bug
Something isn't working
Comments
jameshadfield
added a commit
that referenced
this issue
Jun 12, 2024
Branch labels were already rendered correctly on the RHS tree if the key was present in the LHS tree, so all that's required is to add label keys which are only observed in the RHS tree to appear in the sidebar branch label selector. Closes #1780
jameshadfield
added a commit
that referenced
this issue
Jun 12, 2024
Branch labels were already rendered correctly on the RHS tree if the key was present in the LHS tree, so all that's required is to add label keys which are only observed in the RHS tree to appear in the sidebar branch label selector. Closes #1780
jameshadfield
added a commit
that referenced
this issue
Jun 17, 2024
Branch labels were already rendered correctly on the RHS tree if the key was present in the LHS tree, so all that's required is to add label keys which are only observed in the RHS tree to appear in the sidebar branch label selector. Closes #1780
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Branch label keys unique to the RHS tree don't appear in the branch labels dropdown list, (presumably) due to us not considering the RHS tree when we collect them.
Branch labels are able to be rendered on the RHS tree, assuming that the key also appears in the LHS tree and thus in the dropdown.
The text was updated successfully, but these errors were encountered: