Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tanglegrams] Node info modal broken #1770

Closed
jameshadfield opened this issue Apr 17, 2024 · 1 comment
Closed

[tanglegrams] Node info modal broken #1770

jameshadfield opened this issue Apr 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jameshadfield
Copy link
Member

Clicking on a terminal node or shift-clicking on a branch in the right-hand tree of a tanglegram brings up a modal showing information for another node in the tree.

Hover:
image

Click:
image
@jameshadfield jameshadfield added the bug Something isn't working label Apr 17, 2024
@jameshadfield jameshadfield changed the title Node info modal for tangletrees are broken [tanglegrams] Node info modal broken May 23, 2024
jameshadfield added a commit that referenced this issue Jun 6, 2024
@jameshadfield
[tangletrees] fix node-click modal for RHS tree
d59dbd5 
This bug arrived with recent work which lifted the selected node state
out of component state and into redux¹, where I forgot to consider
tangletrees so that we always ended up retrieving the node (via array
index) from the LHS tree.

Closes <#1770>

¹ <#1749>
@jameshadfield
Copy link
Member Author

Closed by #1783 (Released in Auspice 2.54.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jameshadfield