Filtering being deactivated after clicking away from metadata popup #1701
Labels
bug
Something isn't working
Comments
|
I'm being ghosted by my sequences whenever I click on them. Will this be fixed soon? |
|
Noting this bug is part of the larger issue of the tip modal state not being accurately tracked in the redux state as described by @jameshadfield in #1243 (comment). |
|
Thank you for providing the background @joverlee521. Is there an estimate of when it will be fixed? |
jameshadfield
added a commit
that referenced
this issue
Feb 5, 2024
Clicking on a tip activates a modal and activates the corresponding strain filter. Previously clearing the modal would always inactivate the filter. In the absence of any filtering this behaviour is not bad, but when already filtering to a set of strains then it's counter-intuitive because we inactivate a filter that was active. The new behaviour restores the filtering state of the strain before the modal was opened. Specifically, * If the tip was already filtered, opening and closing the modal doesn't change the filters. * If the tip was filtered but inactive, opening the modal activates it and closing the modal returns it to the inactive state. * If the tip wasn't filtered (active or inactive) then opening the modal makes it an active filter and closing the modal removes the filter entirely. Closes #1701
jameshadfield
added a commit
that referenced
this issue
Feb 6, 2024
Clicking on a tip activates a modal and activates the corresponding strain filter. Previously clearing the modal would always inactivate the filter. In the absence of any filtering this behaviour is not bad, but when already filtering to a set of strains then it's counter-intuitive because we inactivate a filter that was active. The new behaviour restores the filtering state of the strain before the modal was opened. Specifically, * If the tip was already filtered, opening and closing the modal doesn't change the filters. * If the tip was filtered but inactive, opening the modal activates it and closing the modal returns it to the inactive state. * If the tip wasn't filtered (active or inactive) then opening the modal makes it an active filter and closing the modal removes the filter entirely. Closes #1701
|
@jameshadfield I'm still experiencing this issue. |
|
@kvargha the fix was merged and released in Auspice version 2.52.0, but nextstrain.org has not been updated yet. We may do that sometime this week. In the meantime, you can use https://next.nextstrain.org which is automatically updated with the latest version of Auspice. |
|
Gotcha. Thank you @victorlin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current Behavior
When you click on a filtered sample and click away from the popup, the filter becomes deactivated.
Expected behavior
The filtered shouldn't be deactivated.
How to reproduce
Steps to reproduce the current behavior:
Your environment: if browsing Nextstrain online
Additional context
The text was updated successfully, but these errors were encountered: