Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narratives with multiple datasets with measurements #1603

Closed
joverlee521 opened this issue Nov 29, 2022 · 2 comments · Fixed by #1663
Closed

Narratives with multiple datasets with measurements #1603

joverlee521 opened this issue Nov 29, 2022 · 2 comments · Fixed by #1663
Assignees
Labels
bug Something isn't working narratives issues / PRs relating to narrative functionality

Comments

@joverlee521
Copy link
Contributor

joverlee521 commented Nov 29, 2022

Current Behavior

Narratives error when navigating between slides that contain different datasets that both have measurements sidecar JSONs.

How to reproduce

Steps to reproduce the current behavior:

  1. Drag this test narrative onto the narratives debugger.
  2. Successfully navigate between slide 1 and 2.
  3. Navigating to slide 3 or 4 will result in error.

Additional context

First saw this error in a private narrative for seasonal flu that switched between builds of h3n2, h1n1pdm, and vic that all had measurements sidecars.

@joverlee521 joverlee521 added the bug Something isn't working label Nov 29, 2022
@victorlin victorlin moved this from New to Backlog in Nextstrain planning (archived) Nov 30, 2022
@victorlin victorlin added the narratives issues / PRs relating to narrative functionality label Nov 30, 2022
@huddlej
Copy link
Contributor

huddlej commented Mar 20, 2023

@joverlee521 I get a slightly different error but maybe for the same reason when switching between slides in a narrative where the first slide is a standard Auspice view and the second slide has an auspiceMainDisplayMarkdown block. Neither slides reference the meaurements panel, but when toggling from the first to second slide, I get the error shown in the screen capture below of "Failed to load measurements collections (intermediate value).map is not a function".

narratives-measurements-panel-error-without-measurements-panel-enabled.mp4

Sometimes this error happens on the first transition from the first to second slide. Other times it happens only during the second transition down, as shown in the screen capture.

@huddlej
Copy link
Contributor

huddlej commented Mar 21, 2023

I should have noted that the first slide displays an NA tree while the next slide uses an HA tree as its data URL even though its a fully markdown slide.

@joverlee521 joverlee521 self-assigned this Apr 19, 2023
jameshadfield added a commit that referenced this issue Apr 20, 2023
Adds a small dev-use-only script to download the dataset +
sidecar files from a given nextstrain.org URL and give them
the correct filename so that you can test the same URL pathname
from localhost auspice.

I've wanted this for ages but #1603 finally motivated me to do it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working narratives issues / PRs relating to narrative functionality
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants