Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Labels make branch covered by it unclickable #1580

Closed
corneliusroemer opened this issue Oct 21, 2022 · 1 comment · Fixed by #1584
Closed

BUG: Labels make branch covered by it unclickable #1580

corneliusroemer opened this issue Oct 21, 2022 · 1 comment · Fixed by #1584
Labels
bug Something isn't working

Comments

@corneliusroemer
Copy link
Member

Current Behavior

When there is label text that overlays a branch, the branch becomes unclickable

Expected behavior

Labels do not act as a real layer that prevents clicks of the branch below

How to reproduce

2022-10-21 12 38 37

Your environment: if running Nextstrain onlinee

  • Operating system: M1 Mac
  • Browser: Brave
  • Version (e.g. auspice 2.7.0): 2.40.0
@corneliusroemer corneliusroemer added the bug Something isn't working label Oct 21, 2022
@jameshadfield
Copy link
Member

I think setting the appropriate pointer-event on the SVG text element should fix this. I'll take a look...

jameshadfield added a commit that referenced this issue Oct 23, 2022
@jameshadfield
Branch labels don't capture click events
1fd61fc 
There is currently no on-hover behavior for branch labels and they
have a tendency to obscure branches behind them and make them
un-clickable.

Closes #1580
@jameshadfield jameshadfield mentioned this issue Oct 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Branch labels don't capture click events nextstrain/auspice
2 participants
@jameshadfield @corneliusroemer