Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Make Esc dismiss sample details popup #1479

Closed
corneliusroemer opened this issue Mar 8, 2022 · 1 comment · Fixed by #1485
Closed

ENH: Make Esc dismiss sample details popup #1479

corneliusroemer opened this issue Mar 8, 2022 · 1 comment · Fixed by #1485
Labels
enhancement New feature or request

Comments

@corneliusroemer
Copy link
Member

Context

I often (shift)-click on samples or branches to see details.

Right now, to dismiss the popup, I need to click outside the popup, requiring a mouse movement which is a little cumbersome.

I've repeatedly found myself hitting esc in the expectation that it would dismiss the popup, which it didn't do.

Description

It would be nice if esc dismissed the details popup, just how clicking outside does at the moment.

I'm talking about this popup:
image
@corneliusroemer corneliusroemer added the enhancement New feature or request label Mar 8, 2022
@jameshadfield
Copy link
Member

Seems sensible and easy 👍

jameshadfield added a commit that referenced this issue Mar 16, 2022
@jameshadfield
[tree] escape key dismisses any info modal
ed4bf13 
This implements what we think is an intuitive UI, and also helps with
the bug described in #1243 where removing/disabling a strain-filter
results in the tree visualisation falling out-of-sync with the modal.

See #1479 for context.

Closes #1479
@jameshadfield jameshadfield mentioned this issue Mar 16, 2022
Merged
@victorlin victorlin moved this from New to In Review in Nextstrain planning (archived) Mar 16, 2022
@joverlee521 joverlee521 changed the title ENH: Make Esc dismiss sample details popup z Mar 16, 2022
@joverlee521 joverlee521 changed the title z ENH: Make Esc dismiss sample details popup Mar 16, 2022
jameshadfield added a commit that referenced this issue Mar 17, 2022
@jameshadfield
[tree] escape key dismisses any info modal
25e5906 
This implements what we think is an intuitive UI, and also helps with
the bug described in #1243 where removing/disabling a strain-filter
results in the tree visualisation falling out-of-sync with the modal.

Note that `event.key` may not be implemented in all browsers, however
this functionality is a nicety rather than a must-have, so this is
tolerable. Thanks to @joverlee521 for suggesting to use this instead of
`event.keyCode` during PR review.

See #1479 for context.

Closes #1479
Repository owner moved this from In Review to Done in Nextstrain planning (archived) Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Nextstrain planning (archived)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tree] escape key dismisses any info modal nextstrain/auspice
2 participants
@jameshadfield @corneliusroemer