Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift-clicking branches causes crash for datasets without mutations defined #1474

Closed
jameshadfield opened this issue Feb 23, 2022 · 1 comment
Closed

Shift-clicking branches causes crash for datasets without mutations defined #1474

jameshadfield opened this issue Feb 23, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@jameshadfield
Copy link
Member

jameshadfield commented Feb 23, 2022 •
edited
Loading

Current Behaviour

Shift-clicking on a branch of certain trees causes the app to crash.

How to reproduce

The attachment contains two trees from the zika-tutorial build. The tree with no mutations defined causes auspice to crash when shift-clicking on a branch.

The development version of auspice points to the source of the bug:

Uncaught TypeError: can't convert undefined to object
    categoriseMutations treeMiscHelpers.js:176
    getBranchMutations treeMiscHelpers.js:243
    MutationTable

Your environment
Auspice 2.33.0

Archive.zip
@jameshadfield jameshadfield added the bug Something isn't working label Feb 23, 2022
@jameshadfield jameshadfield transferred this issue from nextstrain/auspice.us Feb 23, 2022
@jameshadfield jameshadfield changed the title Shift-clicking branches causes crash Shift-clicking branches causes crash for datasets without mutations defined Feb 23, 2022
jameshadfield added a commit that referenced this issue Feb 23, 2022
@jameshadfield
[bugfix] Allow datasets without mutations
eddc395 
See #1474 for more context
jameshadfield added a commit that referenced this issue Feb 23, 2022
@jameshadfield
[bugfix] Allow datasets without mutations
fb05e73 
See #1474 for more context
@jameshadfield jameshadfield mentioned this issue Feb 23, 2022
Merged
@jameshadfield jameshadfield moved this from New to In Review in Nextstrain planning (archived) Feb 23, 2022
@jameshadfield
Copy link
Member Author

Fixed by #1475

Repository owner moved this from In Review to Done in Nextstrain planning (archived) Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
Nextstrain planning (archived)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jameshadfield