Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core-vendors and other-vendors chunks have different hashes building locally vs GitHub CI #1190

Open
eharkins opened this issue Jul 21, 2020 · 1 comment
Open

core-vendors and other-vendors chunks have different hashes building locally vs GitHub CI #1190

eharkins opened this issue Jul 21, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@eharkins
Copy link
Contributor

Creating this from de9439f

This isn't my area of expertise so apologies for any inaccurate info.

Current Behavior

For unknown reasons, the core-vendors and other-vendors chunks have different hashes when building locally compared with via GitHub CI. This is after running npm ci to mimic the CI conditions. An issue should be created to better understand this, as it implies that the contents differ.

Expected behavior
Github CI bundle hashes are the same as local if nothing has changed.

How to reproduce
cc @jameshadfield who identified this bug. I haven't had the chance to reproduce yet, I'm just opening this up for now so that we have a placeholder.

Your environment: if running Nextstrain locally
same as above ^

Github CI OS info

Additional context
#1164 (comment) maybe relevant?
@eharkins eharkins added the bug Something isn't working label Jul 21, 2020
@eharkins
Copy link
Contributor Author

Maybe closed by b343979 ? If so, sorry for jumping the gun before reading on in that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eharkins