Skip to content

Commit

Permalink
Specifically import d3-transition
Browse files Browse the repository at this point in the history
After code splitting (PR #701) the `transition` prototype was,
depending on the dataset, not set on `Selection()` objects.
See d3/d3-selection#185 for some background info.
This commit closes #708
  • Loading branch information
jameshadfield committed Feb 27, 2019
1 parent 0a1c8ce commit d10fcc0
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 0 deletions.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@
"d3-shape": "^1.2.0",
"d3-time-format": "^2.0.5",
"d3-timer": "^1.0.7",
"d3-transition": "^1.2.0",
"d3-zoom": "^1.1.3",
"docusaurus": "^1.6.2",
"es6-object-assign": "^1.1.0",
Expand Down
1 change: 1 addition & 0 deletions src/components/entropy/entropyD3.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/* eslint no-underscore-dangle: off */
import { select, event as d3event } from "d3-selection";
import 'd3-transition';
import { scaleLinear } from "d3-scale";
import { axisBottom, axisLeft } from "d3-axis";
import { format } from "d3-format";
Expand Down
1 change: 1 addition & 0 deletions src/components/entropy/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import React from "react";
import PropTypes from 'prop-types';
import { connect } from "react-redux";
import { select } from "d3-selection";
import 'd3-transition';
import Card from "../framework/card";
import { changeColorBy } from "../../actions/colors";
import { tabGroup, tabGroupMember, tabGroupMemberSelected } from "../../globalStyles";
Expand Down
1 change: 1 addition & 0 deletions src/components/frequencies/functions.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { select, mouse } from "d3-selection";
import 'd3-transition';
import { scaleLinear } from "d3-scale";
import { axisBottom, axisLeft } from "d3-axis";
import { rgb } from "d3-color";
Expand Down
1 change: 1 addition & 0 deletions src/components/frequencies/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React from "react";
import { select } from "d3-selection";
import 'd3-transition'
import { connect } from "react-redux";
import Card from "../framework/card";
import { calcXScale, calcYScale, drawXAxis, drawYAxis, areListsEqual,
Expand Down
1 change: 1 addition & 0 deletions src/components/map/map.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import leaflet from "leaflet";
import _min from "lodash/min";
import _max from "lodash/max";
import { select } from "d3-selection";
import 'd3-transition'
import leafletImage from "leaflet-image";
import Card from "../framework/card";
import { drawDemesAndTransmissions, updateOnMoveEnd, updateVisibility } from "./mapHelpers";
Expand Down
1 change: 1 addition & 0 deletions src/components/tree/reactD3Interface/initialRender.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { select } from "d3-selection";
import 'd3-transition';
import { rgb } from "d3-color";
import { calcBranchStrokeCols } from "../../../util/colorHelpers";
import * as callbacks from "./callbacks";
Expand Down
1 change: 1 addition & 0 deletions src/components/tree/tangle/index.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/* eslint-disable space-infix-ops */
import React from "react";
import { select } from "d3-selection";
import 'd3-transition';

const makeTipPathGenerator = (props) => (idxs) => {
const tip1 = props.leftNodes[idxs[0]].shell;
Expand Down

0 comments on commit d10fcc0

Please sign in to comment.