Merge pull request #1657 from nextstrain/continous-scale-fixes-2

Continous scale fixes 2
nextstrain · Jun 6, 2023 · 8c53f60 · 8c53f60
2 parents 4b06389 + 17d8ef0
commit 8c53f60
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/src/util/colorScale.js b/src/util/colorScale.js
@@ -110,7 +110,7 @@ export const calcColorScale = (colorBy, controls, tree, treeToo, metadata) => {
       colorBy,
       version: controls.colorScale === undefined ? 1 : controls.colorScale.version + 1,
       legendValues: ["unknown"],
-      legendBounds: createLegendBounds(["unknown"]),
+      legendBounds: {unknown: [-Infinity, Infinity]},
       genotype: null,
       scaleType: null,
       domain: [],
@@ -393,15 +393,19 @@ function booleanColorScale(val) {
   return "#CBB742";
 }
 
+/**
+ * @param {Array<Number>} legendValues
+ * @returns {Record<Number, [Number, Number]>}
+ */
 function createLegendBounds(legendValues) {
   const valBetween = (x0, x1) => x0 + 0.5*(x1-x0);
   const len = legendValues.length;
   const legendBounds = {};
-  legendBounds[legendValues[0]] = [0, valBetween(legendValues[0], legendValues[1])];
+  legendBounds[legendValues[0]] = [-Infinity, valBetween(legendValues[0], legendValues[1])];
   for (let i = 1; i < len - 1; i++) {
     legendBounds[legendValues[i]] = [valBetween(legendValues[i-1], legendValues[i]), valBetween(legendValues[i], legendValues[i+1])];
   }
-  legendBounds[legendValues[len-1]] = [valBetween(legendValues[len-2], legendValues[len-1]), 10000];
+  legendBounds[legendValues[len-1]] = [valBetween(legendValues[len-2], legendValues[len-1]), Infinity];
   return legendBounds;
 }