Update docs build #1187
Merged
Update docs build #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was prompted by an issue with RTD (readthedocs/readthedocs.org#10171) which caused recent docs builds to fail with I thought this was because Python 3.7 got removed in favor of newer versions (hence c630ad6), but it looks like newer versions are also affected. These changes should still be worth having though. Will wait for the RTD issue to be fixed and then merge this. |
victorlin
force-pushed
the
victorlin/fix-rtd
branch
from
c630ad6 to
6b501cd
Compare
|
Dropped c630ad6 since it's not necessary as of now, and the 3.11 build fails anyways since cvxopt fails to build (though 3.10 should work with pre-built cvxopt wheels). I'm going to rebase to enable docs CI, then merge once checks have passed. |
This is recommended¹. Without it, 3.10 will be interpreted as "3.1". ¹ https://docs.readthedocs.io/en/stable/config-file/v2.html#python-version-legacy
python.version is deprecated¹. This also requires defining build.os which is probably a good thing to do anyways. ¹ https://docs.readthedocs.io/en/stable/config-file/v2.html#python-version
victorlin
force-pushed
the
victorlin/fix-rtd
branch
from
6b501cd to
c1ad27e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
See commit messages.
Testing
What steps should be taken to test the changes you've proposed?
If you added or changed behavior in the codebase, did you update the tests, or do you need help with this?
Checklist
Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.N/A no functional changes