Prefer to use CacheFunnel implementation when available for caching non-trivial objects #4077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
non-trivial objects. This change will allow us to define custom caching strategies for objects that are also Maps (custom Meta objects, for example). Signed-off-by: Rob Syme <[email protected]>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Jul 4, 2023
pditommaso
force-pushed
the
master
branch
2 times, most recently
from
81f7cb7 to
8a43489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow us to define custom caching strategies for objects that are also Maps (custom Meta objects, for example).
Currently, if a Map-like object implements CacheFunnel, it is never used because the CacheHelper's
value instanceof Mapwill return true earlier than the testvalue instanceof CacheFunnel.