Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chmod command to accommodate hidden files in bindir (or empty bindir) #3247

Merged
merged 4 commits into from
Sep 27, 2022
Merged

Fix chmod command to accommodate hidden files in bindir (or empty bindir) #3247

merged 4 commits into from
Sep 27, 2022

Conversation

abhi18av
Copy link
Member

This PR addresses the suggestion in #3227 (comment)

@abhi18av abhi18av linked an issue Sep 26, 2022 that may be closed by this pull request
A top-level bin folder with hidden files (e.g. .gitkeep) results in failure on cloud based runs #3227
Closed
@abhi18av abhi18av changed the title Fix chmod command to accommodate hidden files in bindir Fix chmod command to accommodate hidden files in bindir (or empty bindir) Sep 26, 2022
@bentsherman
Copy link
Member

From our discussion today, the command should be:

chmod +x $PWD/nextflow-bin/{.*,*}

@pditommaso
Copy link
Member

yeah the -R recurse the subdir which may not be desirable. I think it could be even better using

chmod +x $PWD/nextflow-bin/* || true

@bentsherman
Copy link
Member

Yes, I like the || true better.

@abhi18av
Copy link
Member Author

Thanks @bentsherman @pditommaso for the review, I have now accommodated the feedback.

@sonatype-lift
Copy link

sonatype-lift bot commented Sep 27, 2022

⚠️ 7 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

@pditommaso pditommaso merged commit 1d71fa9 into master Sep 27, 2022
@pditommaso pditommaso deleted the abhinav/fix-chmod-empty-bindir branch September 27, 2022 14:10
Lehmann-Fabian pushed a commit to Lehmann-Fabian/nextflow that referenced this pull request Sep 27, 2022
@abhi18av @Lehmann-Fabian
Fix chmod command to accommodate hidden files in bindir (or empty bin…
c150e78 
…dir) (nextflow-io#3247)
pditommaso pushed a commit that referenced this pull request Sep 27, 2022
@abhi18av @pditommaso
Fix chmod command to accommodate hidden files in bindir (or empty bin…
01eacf3 
…dir) (#3247)

Signed-off-by: Paolo Di Tommaso <[email protected]>
pditommaso pushed a commit that referenced this pull request Sep 27, 2022
@abhi18av @pditommaso
Fix chmod command to accommodate hidden files in bindir (or empty bin…
a0fcc7b 
…dir) (#3247)

Signed-off-by: Paolo Di Tommaso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsherman bentsherman bentsherman approved these changes

@jorgeaguileraseqera jorgeaguileraseqera Awaiting requested review from jorgeaguileraseqera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A top-level bin folder with hidden files (e.g. .gitkeep) results in failure on cloud based runs
3 participants
@abhi18av @bentsherman @pditommaso