-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the azcopy options configuration scope #3090
Conversation
@pditommaso this PR is ready from my side - but depends on a sister PR nextflow-io/azcopy-tool#1 where I've mentioned the major benefit of the update since we source the UPDATE: Keeping this as draft so as not to merge accidentally before the sister PR. |
Quick update: I've had to remove the options which are not compatible with the older The following config with custom azcopy opts are reflected on the generated
The only problem remains to be solved is the last test in nextflow/plugins/nf-azure/src/test/nextflow/cloud/azure/file/AzBashLibTest.groovy Line 163 in db89af1
|
@pditommaso , shall we merge the PR with this edge release cycle? |
Abi, there's the usual problem your PRs do not run the tests and I've tested locally and it fails |
2c461f8
to
23432f3
Compare
🤔 this is curious. Let me take a look why there's no automated testing here. |
e2b4a93
to
f32ea0b
Compare
cefb067
to
e523afd
Compare
0d59b4c
to
b93634e
Compare
We lost the momentum on this. Closing it because I don't know the status of this PR |
True 😞 But quick question, do you think that this effort would be a useful addition since |
That's another good point. The ideal goal is to not rely anymore on azcopy and use instead fusion in the mid-term |
I see, in that case let me know if there's a need for the retouches on this PR and then I can make the iteration and circle back. Otherwise, I agree, good opportunity to showcase |
This PR builds upon the available settings with the core
azcopy
tool which is used for uploads and downloads in the context of Azure Blob storage service.