Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create nextcloud_vm #1120

Closed
wants to merge 14 commits into from
Closed

create nextcloud_vm #1120

wants to merge 14 commits into from

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Feb 29, 2020

No description provided.

@szaimen szaimen mentioned this pull request Feb 29, 2020
6 tasks
@szaimen
Copy link
Collaborator Author

szaimen commented Feb 29, 2020

@enoch85 I need help here: the idea is to have this one script, that just has to get downloaded once and works without needing other resources like lib.sh

for now two questions:

  • Do we want to verify the state of the downloaded package with a checksum?
  • what is a good place where to download the .tar file to?

@enoch85
Copy link
Member

enoch85 commented Feb 29, 2020

In such a big change I think it's better to change the lib location to your repository first, just to be able to test all the changes before we push to master.

If this is breaking it's catastrophic.

@szaimen
Copy link
Collaborator Author

szaimen commented Feb 29, 2020

we don't change the lib location: please look at https://github.com/nextcloud/vm/pull/1120/files#diff-90b7ea30bc531dd051547e9ec21aeb32R19-R21

Sry, I didn't get what you meant.
I think changing the lib to my repository is not necessary since the startup script and everything else still can run without this script.

@enoch85 Please first check out the comments what it does.

@szaimen
Copy link
Collaborator Author

szaimen commented Feb 29, 2020

Actually this script will be a bit like cloning the repo to "$SCRIPTS"
but instead we will download the release tar file and check the integrity

@szaimen
Copy link
Collaborator Author

szaimen commented Feb 29, 2020

@enoch85 Please could you answer those two questions:

  • Do we want to verify the state of the downloaded package with a checksum?
  • what is a good place where to download the .tar file to?

@szaimen
Copy link
Collaborator Author

szaimen commented Feb 29, 2020

closing in favour of #1126

@szaimen szaimen closed this Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants